Repository navigation
test: the consumer smoke test runs on an EF Core the packages were not built with - #144
Merged
Merged
Conversation
…t built with SMOKE_EF_VERSION makes every consumer reference Microsoft.EntityFrameworkCore.Relational at that version directly; the design package, the host and dotnet-ef follow it, and a row checks that the consumer resolved it. With 11.0.0, over Npgsql EF rc.3's exact pin (NU1608), every row passed on PostgreSQL 18.4. Closes #143 Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
CaffeinatedCoder
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143
Problem
Every suite ran on EF Core
11.0.0-rc.3, which Npgsql EF11.0.0-rc.3pins exactly. A consumer that references EF Core 11.0.0 directly gets it, with NU1608 and a build, and nothing said what that consumer gets. The smoke test had no way to run on another EF Core than the kernel's own dependency.Change
SMOKE_EF_VERSIONintest/ConsumerSmokeTest/run.sh: the consumers'Directory.Build.propsgets a direct reference toMicrosoft.EntityFrameworkCore.Relationalat that version for every project but the judge, andEfVersion(the design package, the host,dotnet-ef) follows it.Microsoft.EntityFrameworkCoreand.Relationalin the consumer'sproject.assets.json, so the run cannot pass on the packages' own version.CLAUDE.md: the command, and the measurement under "Upstream pins".Tests
SMOKE_EF_VERSION=11.0.0locally on PostgreSQL 18.4: 48 rows, all passed, in 48 s. The consumer'sdeps.jsonholds EF Core 11.0.0 beside Npgsql EF 11.0.0-rc.3, and the build log NU1608 for both pins;dotnet-ef11.0.0. The details are on The consumer smoke test on an EF Core the packages were not built with: SMOKE_EF_VERSION, and the run on 11.0.0 #143.🤖 Generated with Claude Code