Fixing: #298 and #300 - Signal Handler, Table Truncation and CHANGLOG Updates#316
Merged
TheWitness merged 5 commits intodevelopfrom Apr 10, 2026
Merged
Fixing: #298 and #300 - Signal Handler, Table Truncation and CHANGLOG Updates#316TheWitness merged 5 commits intodevelopfrom
TheWitness merged 5 commits intodevelopfrom
Conversation
Member
TheWitness
commented
Apr 10, 2026
TheWitness
commented
- This should stop the table truncation after install, it will flip the table to use the 'upgrade' process over the truncate process.
- Most of the issues around syslog poller: lock timeout, signal handler, and earlier partition rotation #298 have been corrected with the exception of signal handling in syslog_process which is now addressed.
- Also doing CHANGELOG.md catchup commit
* This should stop the table truncation after install, it will flip the table to use the 'upgrade' process over the truncate process. * Most of the issues around #298 have been corrected with the exception of signal handling in syslog_process which is now addressed. * Also doing CHANGELOG.md catchup commit
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses syslog plugin stability and install/upgrade behavior issues (notably #298 and #300) by improving poller shutdown handling and preventing unintended table truncation/drops, plus updating the changelog.
Changes:
- Add UNIX signal handling and runtime/output flushing adjustments to
syslog_process.php. - Update install/upgrade logic in
setup.phpto prefer upgrade behavior and use a column-existence helper forsyslog_reports. - Catch up
CHANGELOG.mdentries for recent issues/fixes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| syslog_process.php | Adds signal handler setup and modifies runtime/output settings for the syslog poller process. |
| setup.php | Adjusts table setup logic to avoid repeated truncation and updates column existence checking for syslog_reports. |
| CHANGELOG.md | Adds missing issue entries related to recent syslog fixes/hardening work. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
xmacan
approved these changes
Apr 10, 2026
xmacan
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.