Skip to content

feat(user): 회원정보 수정에 name 필드 추가#77

Merged
chanwoo7 merged 1 commit intodevelopfrom
feat/mypage-figma-profile-name
Apr 29, 2026
Merged

feat(user): 회원정보 수정에 name 필드 추가#77
chanwoo7 merged 1 commit intodevelopfrom
feat/mypage-figma-profile-name

Conversation

@chanwoo7
Copy link
Copy Markdown
Member

@chanwoo7 chanwoo7 commented Apr 29, 2026

Summary

  • 마이페이지 figma 명세 03-profile-edit의 '이름 입력 (필수값)' 정책 반영
  • updateMyProfile에 name 처리 추가 + 필수값 검증
  • name은 Account 테이블, 나머지(닉네임/생일/전화)는 user_profile 테이블이라 transaction으로 묶음

변경 사항

  • SDL UpdateMyProfileInput에 name: String 추가
  • TS DTO 및 codegen 갱신
  • service: hasName 분기 + normalizeName 검증 (trim 후 빈 문자열은 reject)
  • repository: updateProfile args에 name? 추가, account/user_profile update를 단일 transaction으로 묶음
  • 회귀 테스트 6건
    • name만 단독 업데이트
    • trim 동작
    • 빈 문자열 reject
    • 공백-only reject
    • name + nickname 동시 업데이트
    • name 미지정 시 기존 값 유지

Breaking 여부

  • ❌ Breaking 아님. SDL에 옵셔널 필드만 추가
  • 기존 호출 (name 미전송)은 동작 변경 없음

Test plan

  • 로컬 yarn test:cov 통과 (837 tests)
  • CI check 통과
  • CI coverage-report 통과
  • CodeQL 통과

마이페이지 figma 명세에 따라 회원정보 수정 화면에서 이름 변경을 지원한다.
'필수값' 표시에 따라 전송 시 trim 후 빈 문자열은 reject.

- SDL UpdateMyProfileInput에 name: String 추가
- TS DTO 동기화
- service: hasName 분기 + normalizeName 검증 + repository 호출
- repository: updateProfile args에 name 추가, account/user_profile 양쪽 update를
  transaction으로 묶어 부분 실패 방지
- 회귀 테스트 6건 (name 단독/trim/빈값/공백/동시업데이트/미지정 시 유지)
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a7df78f2-3da7-4c60-a3ff-8b38727e9d81

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/mypage-figma-profile-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 96.59% 2801/2900
🟢 Branches 86.58% 1606/1855
🟢 Functions 93.09% 593/637
🟢 Lines 96.93% 2557/2638

Test suite run success

837 tests passing in 75 suites.

Report generated by 🧪jest coverage report action from 4e7a443

@chanwoo7 chanwoo7 merged commit defcddb into develop Apr 29, 2026
9 checks passed
@chanwoo7 chanwoo7 deleted the feat/mypage-figma-profile-name branch April 29, 2026 16:04
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant