Repository navigation
Remove process-local search controls for public testing - #136
Merged
Merged
Conversation
afoote-mitre
marked this pull request as draft
August 20, 2026 22:22
afoote-mitre
marked this pull request as ready for review
August 21, 2026 14:09
jdaigneau5
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the process-local search performance proof of concept so the public-testing branch focuses on the core API contract and search behavior.
Why This Change Is Needed
The in-process cache, request coalescing, cold-search queue, performance metrics, and rate limiter were temporary evaluation mechanisms. They are not intended to be the production architecture: public rate enforcement is owned by AWS WAF, and any future shared cache, admission control, or telemetry should be implemented with deployment-level AWS services rather than independent state in each API process.
Keeping those controls in the public-testing code would add configuration and operational complexity without providing consistent behavior across ECS tasks.
Changes
/searchexecution to call OpenSearch directly while retaining request deadlines, transport cancellation, response validation, sanitized errors, exact in-bound totals, and the existing semantic candidate/filter/page-fetch strategy.express-rate-limitdependency, and HTTP 429 OpenAPI contract.adm-zip@0.6.0override to remediateGHSA-xcpc-8h2w-3j85in the transitivecve-coredependency path; the production dependency audit now reports zero vulnerabilities.Preserved Proof Of Concept
The removed implementation remains available on
af/search-performance-poc-archiveat commitad2546a. That branch includesdocs/search-performance-proof-of-concept.md, which documents the prior flow and a migration path to AWS Valkey, WAF/ALB/ECS controls, and CloudWatch/OpenTelemetry/X-Ray.