Removed _diffrn.id names that belong in multi-block dictionary. - #641
Merged
Conversation
Collaborator
|
The cell-measurement-multi-block.cif file in the examples/ directory should most likely also be moved to cif_core_multiblock repository as it uses these data names. Alternatively, it should be updated to explicitly state that it uses the multiblock dictionary. I think it somewhat makes sense to at least leave a copy of this example file in this repository since together with cell-measurement-single-block.cif they showcase the old and the new (recommended) way of organizing data side by side. |
vaitkus
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going through core CIF as I revise the core CIF chapter in Vol G, I found that
_diffrn.idand friends are in core while also being in multiblock. This PR removes them.This also means removing
_cell.diffrn_id. My understanding of #442 is that this data name was a mistake and was probably never used. If necessary, we can add it as a deprecated data name in the multi-block dictionary.Once merged I will backport this to
rc-3.3.0.