Repository navigation
feature: React foundation – Workstream 1 (react-app/ scaffold, routes, typed API hooks, settings context) - #917
Open
devin-ai-integration[bot] wants to merge 12 commits into
Open
devin-ai-integration[bot] wants to merge 12 commits into
devin-ai-integration[bot] wants to merge 12 commits into
Conversation
…ks, settings context, shared library) Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…d tests Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…CI and Firebase hosting Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…d user profile to React Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…ils-user feature: React item details (recursive collapsible comments, polls) + user profile
…ormalization) Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
feature: React shell (header, footer, settings), theming, PWA, e2e, CI and hosting
feature: port feeds (FeedList, FeedItem) to React (Workstream 2)
…eams are merged Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…igation incl. rapid Back Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
…http(s) only) Co-Authored-By: Ishita Gupta <ishita.gupta@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration branch for the Angular 9 → React rewrite of the HN PWA, in
react-app/(the Angular app at the repo root is untouched and stays the parity reference).app.routes.ts(/news|newest|show|ask|jobs/:page;/item/:idand/user/:idlazy-loaded). Typed models anduseFeed/useItem/useUserhooks ported fromHackerNewsAPIService, with HN API quirks handled.SettingsProviderpersisted to localStorage.commentLabel(the comment pipe) as a plain function,sanitizeHtml, the shared theme SCSS, Vitest, CI.react-app/MIGRATION.mdholds the contract and the ownership map.FeedListwith Angular pagination (More › at 30 items, ‹ Prev) andFeedItemstory rows, plus title size and row spacing settings.[-]/[+]collapsible comments that work from the keyboard, and the user profile with karma.src/manifest.json, NetworkFirst API caching for offline use, and anngsw-worker.jssafety worker for returning Angular visitors. Playwright e2e, the CI e2e job and Firebase hosting config.Verification
Results on the integrated branch:
Each workstream PR has its own Angular-vs-React side-by-side evidence (1280/375px, all 3 themes).
Not verified: a real Firebase deploy. The
deployjob runs only on pushes to master and skips unlessFIREBASE_SERVICE_ACCOUNT/FIREBASE_TOKENis set.Note: open PRs #897–#916 come from earlier runs of this same migration and duplicate this work. Only one set should land.
Devin-Org: engineering