Repository navigation
Add unit tests for Discussion, BaseMessage, and HTML tag parsing utilities - #8
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ities Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 35 unit tests in a new file
tests/llm/test_discussion.pycovering previously untested utilities inllm_utils.py:Discussionclass: construction (empty, single message, list),add_message/append(from BaseMessage, dict, role+content kwargs), properties (last_message,__len__,__getitem__,__iter__,__str__), conversions (to_string,to_openai,to_markdown), and content helpers (add_text,add_content).BaseMessage/SystemMessage/HumanMessage/AIMessage: role assignment, invalid kwarg rejection,__str__with string and list content,to_markdown.extract_html_tags: single key, multiple matches, missing key, multiline content.parse_html_tags: required vs optional keys, duplicate key handling with and withoutmerge_multiple.parse_html_tags_raise: raisesParseErroron missing keys, returns dict on success.No production code changes.
Review & Testing Checklist for Human
TestDiscussionConversions.test_to_string_mergesshould confirm adjacent text elements actually get merged)uv run pytest tests/llm/test_discussion.py -v— all 35 tests should passNotes