Repository navigation
Conversation
Co-Authored-By: yannis <yannis@cognition.ai>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
There was a problem hiding this comment.
🔍 Devin Review: 3 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
…ENAI_API_KEY Co-Authored-By: yannis <yannis@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only change. No production code is modified. Adds 16 test files (~200 tests) that run offline: LLM clients, API keys, tokenizers and
input()are all faked, so no real model calls are made.Coverage (
pytest -n 8 -m 'not pricy' tests/ --cov=src/agentlab, MiniWoB served locally):mainNew test files, by area:
test_llm_utils_extra.pycoversgeneric_call_api_with_retriesbackoff, retriable vs non-retriable status codes, the OpenAI/Anthropic wrappers,retry_multiple,messages_to_dict,BaseMessage/Discussion, and image encoding.test_chat_api_unit.pycoversChatModelretry/RetryError, pricing, Azure/OpenRouter/vLLM setup,AnthropicChatModelandCheatMiniWoBLLM.test_huggingface_utils_unit.pycovers the chat-template fallback, retries and log_probs.test_litellm_api_unit.pycovers how_call_apibuilds its params (tools, tool_choice, force_call_tool, cache control), tool-call parsing andLiteLLMAPIMessageBuilder.test_prompt_templates.pycovers the prompt templates.test_episode_to_html.py,test_archive_studies.py,test_inspect_results_unit.py(summaries, global and flag reports, error-key mapping, staleness cache,get_study_summaryandget_all_summaries).test_exp_utils.py(timeouts,add_dependencies, deprecated helpers),test_reproducibility_util_extra.py(_verify_report,assert_compatible,append_to_journal),test_study_utils.py.agent_utils,tmlr_config,MostBasicAgent,DebugAgent,add_step_timing_to_env_info_decorator.Things reviewers should know
tests/agents/test_agent.py::test_llm_error_no_successsometimes fails when the full suite runs in parallel with-n 8on a Devin VM, onmainas well as on this branch. It passes on its own and it passes in CI here.inspect_results.categorize_errorandreport_different_errorsreferenceERR_CLASS_MAP, which is never defined. Any row with a non-nullerr_msgraisesNameError. The tests only cover theerr_msg=Nonepath.test_chat_api_unit.py:AnthropicChatModelonly checkshasattr(TRACKER, "instance"), so it crashes if an earlier test leftTRACKER.instance = Nonein the same worker. Autouse fixtures give each test a freshthreading.local()and fake provider API keys.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/43b4472bdcda4c1ebc075b23d0b7f601
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/43b4472bdcda4c1ebc075b23d0b7f601?variant=devin
Requested by: @ipsorakis
Devin Review