Repository navigation
test: unit tests for study, reproducibility_util, args, view_dep_graph, multi_server - #57
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…w_dep_graph, multi_server (5 bug xfails) Co-Authored-By: Daniella Grimberg <daniella@cognition.ai>
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
🔍 Devin Review: 3 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds hermetic unit tests (5 new files, tests only — no
src/or existing-test changes) covering study orchestration and reproducibility bookkeeping without launching experiments.Studyis built from a realbgym.DEFAULT_BENCHMARKS["miniwob_tiny_test"]()+GenericAgentArgs(CheatMiniWoBLLMArgs);run_experiments,prepare_backends,inspect_results, andfind_incompleteare patched.ParallelStudiesuses fakeProcessPoolExecutor/Pool/Manager(no real processes).git.Repo.init(tmp_path)repos with monkeypatchedGIT_AUTHOR_*/GIT_COMMITTER_*; journal tests write totmp_pathonly.view_dep_graphruns plotting at import time, so tests patchbgym.DEFAULT_BENCHMARKS["visualwebarena"]with a fake benchmark, forcematplotlib.use("Agg"), and stubplt.show.Coverage (target modules, new tests only)
experiments.studyexperiments.reproducibility_utilexperiments.argsexperiments.view_dep_graphexperiments.multi_serverRemaining misses:
args.py301-315 is theif __name__ == "__main__"block;study.py345-348 is the no-progress retry stop, unreachable because of thelast_error_countbug below;view_dep_graph.py290 is a defensivehas_nodeguard.Tests
167 tests: 162 passed, 5 xfailed (strict). Each file < 1s–4s; passes serially, with
-n 4, and in random order (pytest-randomly).xfail'd source bugs (
strict=True)study.Study.run:last_error_countis initialized toNoneand never updated, so "Last trial did not reduce the number of errors" never fires.study.SequentialStudies.run: callsself.make_dir()withoutexp_root, so the parent study dir is created underRESULTS_DIRinstead of the givenexp_root.reproducibility_util._get_git_info:repo.index.diff(repo.head.commit)is reversed — a staged new file is reported asDinstead ofA.reproducibility_util.append_to_journal: when creating a new journal, headers come frominfo.keys()only, so result columns (avg_reward,std_err, …) are dropped.multi_server.WebArenaInstanceVars.from_env_vars(prefix=...): the custom prefix isn't stored on the returned instance (it keepsprefix="WA_").Run
Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/5559d53f195643d6843f249e797f1c88
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/5559d53f195643d6843f249e797f1c88?variant=devin
Requested by: @danigrim