Repository navigation
Cover VisualWebArena agent step/parse path with a non-pricy test - #43
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The only test for
VisualWebArenaAgentwas@pytest.mark.pricyand called realgpt-4o-mini, so CI (which runs-m 'not pricy') never executed the agent's prompt assembly or action parsing. Adds a CI-runnable test mirroringtests/agents/test_agent.py: it runs the agent onminiwob.click-testthroughlaunch_exp.run_experimentswith a cheat LLM, asserting one step andcum_reward == 1.0.Two details specific to this agent, versus the generic-agent tests:
messages[1]["content"]as a string, and it only searches after the lastOBSERVATION:marker because the few-shot [REDACTED SECRET]s also containbuttonrows.parser(), i.e. the action inside a fenced code block:...In summary, the next action I will perform isclick("12").make_agent()needsaction_set_args, which is only set byset_benchmark, so the test callsagent_args.set_benchmark(bgym.DEFAULT_BENCHMARKS["miniwob_tiny_test"](), demo_mode=False).Parametrized over
observation_typein("axtree", "axtree_som")so the screenshot/set-of-marks branch ofget_actionis exercised too.Verification: the MiniWoB server could not be started in this session (cloning
Farama-Foundation/miniwob-plusplusis blocked by the session network policy), so the full loop was not run locally; the prompt-build + parse path was verified offline by drivingget_actionwith a synthetic observation for both observation types. CI runs the test with MiniWoB available.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/91414c8499de4805b8b9170ce243343f
Open in Devin Desktop: https://app.devin.ai/desktop/session/91414c8499de4805b8b9170ce243343f?variant=devin