Repository navigation
test: cover make_study dispatch, agent×benchmark enumeration and the relaunch loop - #42
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…launch loop (bug: track last_error_count between trials)
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the code-scan coverage gap on study orchestration:
make_studydispatch,Study.make_exp_args_listenumeration, and theStudy.runrelaunch loop were only exercised by skipped orpricytests. New tests intests/experiments/test_study.pycover them withCheatMiniWoBLLMArgsonminiwob_tiny_test, without launching any experiment or LLM call.Studyfor 1+ agents with no parallel servers (and for a single agent even whenparallel_serversis set),ParallelStudiesfor 2 agents +parallel_servers,SequentialStudiesfor 2 agents onwebarena_tiny.ExpArgsin agent-major order withorder == 0..7._FakeRunStudysubclass stubs_run/get_results/find_incomplete/save/set_reproducibility_infoand replays a scripted(n_incomplete, n_error)sequence per trial, asserting the loop stops when nothing is incomplete, when errors stop decreasing, when >30% errored, and otherwise runs exactlyn_relaunchtimes.Writing the loop tests surfaced a bug:
last_error_countwas initialised toNoneand never updated, so the "last trial did not reduce the number of errors" break was dead code and a study whose error count plateaued kept retrying untiln_relaunch. Fixed inStudy.run:tests/experiments/test_study.pypasses (8 passed, 1 skipped). The 3 failures intest_launch_exp.py::test_launch_system_*reproduce on unmodifiedmainand are unrelated.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/4b25d84785bb4a338e6cd894c3e70752
Open in Devin Desktop: https://app.devin.ai/desktop/session/4b25d84785bb4a338e6cd894c3e70752?variant=devin