Repository navigation
test: cover truncate_tokens start offset and no-op branches - #41
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…: off-by-one window slicing)
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes a coverage gap flagged by a code scan:
truncate_tokenswas only exercised withstart=0and a text longer thanmax_tokens, leaving the offset slice and the already-within-limit return untested.Adds two tests in
tests/llm/test_llm_utils.py:test_truncate_tokens_with_start: pins the exact windowtokens[start:start+max_tokens](start=2, max_tokens=3->" a simple test"), so an off-by-one at either boundary fails.test_truncate_tokens_within_limit_returns_text_unchanged: asserts theelsebranch returns the original string byte-for-byte (no decode round-trip), including the exact-fit boundarylen(tokens) == max_tokens.Note the third assertion documents existing behavior that
startonly shrinks the window it compares against:truncate_tokens(text, max_tokens=4, start=2)returns the whole text (6 tokens) rather than the offset slice, sincelen(tokens) - start <= max_tokens.No production code changed.
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/949458399186449f8cd7a5b706135d59
Open in Devin Desktop: https://app.devin.ai/desktop/session/949458399186449f8cd7a5b706135d59?variant=devin