Repository navigation
test: cover ActionPrompt._parse_answer branches and Trunkater/fit_tokens edges - #39
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ens edges (bug prevention)
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tests/agents/test_dynamic_prompting.pyclosing the coverage gap flagged by the code scan insrc/agentlab/agents/dynamic_prompting.py. No production code changed.Covered branches:
ActionPrompt._parse_answer: happy path +merge_multiple, strict re-raise onParseError, non-strict fallback toextract_code_blocks(joined blocks +parse_errorkey), non-strict re-raise when no blocks,"None"sentinel ->action is None(andto_python_codeis not called, which is what makes the reproducibility replay path work), andto_python_coderaising ->ParseError.Trunkater.shrink: theshrink_calls >= start_trunkate_iterationgate (no deletion on the firststart_trunkate_iterationcalls, deletion on the next), accumulation ofdeleted_linesacross calls, and the hidden case (no deletion butshrink_callsstill increments).fit_tokens:max_prompt_tokens=Nonereturns the prompt untouched, already-fitting prompt returns without shrinking, andadditional_promptssubtraction (count_tokens(p) + 1per prompt) pushing an otherwise-fitting prompt over budget.The parse tests use a
StubActionSetrecordingto_python_codecalls, so no browsergym action set is needed. Thefit_tokenstests monkeypatchdp.count_tokenswith a word counter, keeping them offline (the real tokenizer downloadscl100k_base) and making the budget arithmetic explicit.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/9bb3b2d2ec764e7d9f87f7b89944da04
Open in Devin Desktop: https://app.devin.ai/desktop/session/9bb3b2d2ec764e7d9f87f7b89944da04?variant=devin