Repository navigation
test: cover ReproAgent trace-replay branches - #38
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
tests/agents/test_reproducibility_agent.py, the first test coverage forReproAgent.get_action/ReproChatModel(code scan findingsfind-ed8a0ea, low severity). No production code changes.Covered branches in
reproducibility_agent.py:old_chat_messages is None→ returns(None, AgentInfo(markdown_page=...))carrying the recordederr_msginstead of replaying.len(old_chat_messages) == 2with a recorded action → appends a reconstructed<action>{recorded_action}</action>assistant message (the legacy old-bug workaround) before replay; with no recorded action the discussion stays at 2 messages andReproChatModelfalls back to<action>None</action>.ReproChatModel, and the diff stats attached by_make_agent_statsshow no drift.ReproChatModeldirectly: returnsold_messages[len(messages)], and the<action>None</action>fallback when the new discussion has caught up with the recorded one.The agent is driven with a stub
ExpResult/StepInfo(monkeypatched into the module) andCheatMiniWoBLLMArgs;GenericAgent.get_actionis stubbed with a 2-messageDiscussionthat it pushes throughself.chat_llm, so no LLM or environment is involved.Verified the tests fail when either branch is removed (
if False:mutation of the None-check and of thelen == 2reconstruction).Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/93845d3fb5e24f43b4009c7f7e97ec38
Open in Devin Desktop: https://app.devin.ai/desktop/session/93845d3fb5e24f43b4009c7f7e97ec38?variant=devin