Repository navigation
test: cover tool-call response formatting in CI (non-pricy) - #33
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the code-scan gap where
handle_tool_call/add_responded_tool_calls— the multi-turn tool-use wire formatting for all three providers — was only exercised by@pytest.mark.pricytests that CI (pytest -m 'not pricy') never runs.Adds 13 non-pricy unit tests in
tests/llm/test_response_api.pythat build aToolCallsfrom mocked raw calls (mirroring what each_parse_tool_callsproduces) and assert the exact dicts each builder emits:OpenAIResponseAPIMessageBuilder:function_call→{"type": "function_call_output", "call_id", "output": <str>};computer_call→{"type": "computer_call_output", "call_id", "output": {"type": "input_image", "image_url"}}; raw responseoutputitems are preserved ahead of the responses, including the multi-call ordering case.AnthropicAPIMessageBuilder: assistanttool_useblock followed by a user message whose content is a list of{"type": "tool_result", "tool_use_id", "content": <str>}.OpenAIChatCompletionAPIMessageBuilder: raw assistant message followed by{"name", "role": "tool", "tool_call_id", "content"}.Also covers the guard rails that previously had no CI assertion: image response in a function call, text response in a computer call,
all_responses_setFalse inadd_responded_tool_calls, andprepare_message()on a"tool"builder with noresponded_tool_calls(raisesValueError).No production code changed.
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/8d237cdb781b415ead9ebef85e7b15ae
Open in Devin Desktop: https://app.devin.ai/desktop/session/8d237cdb781b415ead9ebef85e7b15ae?variant=devin