Repository navigation
test: cover multi-action tool call join in non-pricy suite - #30
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
len(actions) > 1branch in_parse_response(AgentlabAction.convert_multiactions_to_agentlab_action_format) was only exercised bytest_multi_action_tool_calls, which is@pytest.mark.pricyand skipped in CI, so a regression in parallel tool-call handling could drop or mis-join actions unnoticed.Adds four non-pricy tests to
tests/llm/test_response_api.py:test_convert_multiactions_to_agentlab_action_format:[] -> None, single action passthrough, two actions joined with\n.test_openai_chat_completion_model_parse_multi_action,test_openai_response_model_parse_multi_action,test_claude_response_model_parse_multi_action: mocked responses with two tool calls, assertingparsed.action == "get_weather(location='Paris')\nget_weather(location='Delhi')"andlen(tool_calls) == 2.create_mock_anthropic_responsenow accepts a list fortool_use(single dict still works):No source changes.
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/5450aa73dd284d88ace11bfa269b8fe9
Open in Devin Desktop: https://app.devin.ai/desktop/session/5450aa73dd284d88ace11bfa269b8fe9?variant=devin