Repository navigation
test: cover ChatModel retry loop, wait-time extraction and cost arithmetic with mocked tests - #29
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ogic (bug risk coverage)
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/llm/test_chat_api.pypreviously contained only live-providerpricytests that are skipped in CI, leavingChatModel.__call__'s retry loop,_extract_wait_time,handle_errorand the cost formula unverified. This adds mocked unit tests for those branches; no source changes.Test harness: a
_FakeClient(passed asclient_class, with the scripted responses fed throughclient_args) whosechat.completions.createpops the next item and raises it if it is an exception;chat_api.time.sleepis monkeypatched to record wait times instead of sleeping, and pricing comes from a stubpricing_func.Covered:
_extract_wait_time: parsed value, clamp tomin_retry_wait_timewhen parsed is smaller, fallback when the regex does not match.handle_error: re-raises non-OpenAIError; sleeps for the extracted duration and returns the error message forOpenAIError.__call__: retry-then-success (retries,error_types, recorded sleeps), retry exhaustion raisingRetryError, retry onusage is None(theOpenRouterErrorpath),n_samples > 1returning all choices.input_tokens * input_cost + output_tokens * output_costviatracking.set_tracker().Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/ba50352dc57249ffafda6be77c60625e
Open in Devin Desktop: https://app.devin.ai/desktop/session/ba50352dc57249ffafda6be77c60625e?variant=devin