Repository navigation
test: cover VisualAgent MainPrompt._parse_answer aggregation - #28
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…k: silent key loss)
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing non-pricy unit test for the visual agent's prompt module.
MainPrompt._parse_answermergesthink.parse_answerandaction_prompt.parse_answerinto one dict; nothing asserted that both survive the merge, so a key change or collision in either sub-parser would silently drop the thought or the action.New
tests/agents/test_visual_agent_prompt.pybuilds a realMainPromptfromDEFAULT_PROMPT_FLAGSand asserts:thinkandactionare present and correct for a well-formed answer;use_thinking=False, the invisibleThinkelement contributes nothing ("think" not in ans_dict) whileactionstill parses;<think>tag surfacesparse_error(Think's non-raising fallback) rather than being swallowed.Runs without a MiniWoB server or any LLM call.
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/627e197fd9264cb3aad32f13e728016d
Open in Devin Desktop: https://app.devin.ai/desktop/session/627e197fd9264cb3aad32f13e728016d?variant=devin