Repository navigation
test: cover parse_html_tags required/optional/repeated/merge branches - #27
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…d/optional/repeated/merge)
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes a test-coverage gap flagged by a code scan:
parse_html_tags/parse_html_tags_raiseis the parser every agent uses to turn raw LLM text into answer dicts, but its branch matrix was only partially exercised (tests/llm/test_llm_utils.pycovered basic single-tag and code-block extraction only).Adds five pure-string tests (no mocks) in
tests/llm/test_llm_utils.pypinning each branch:valid=True, empty retry messagevalid=False, retry message names<action>;parse_html_tags_raiseraisesParseErrormerge_multiple=False->valid=False("multiple instances"), dict keeps the first value; raise variant raisesmerge_multiple=True-> values joined with\n(the pathActionPrompt._parse_answerrelies on for multi-action answers)No production code changed.
pytest tests/llm/test_llm_utils.pypasses (16 tests).Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/ca11b20a11c041be9e2917ea2629777a
Open in Devin Desktop: https://app.devin.ai/desktop/session/ca11b20a11c041be9e2917ea2629777a?variant=devin