Repository navigation
test: cover all messages_to_dict conversion branches - #26
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
messages_to_dict(the dict/str/LangChain ->Discussionboundary used byreproducibility_agentreplay) had no test, including the recently patched LangChainrole_mapfallback. Adds unit tests intests/llm/test_llm_utils.pycovering every branch:{"role": "<unknown role>"}convert_message_to_dictavailable (monkeypatched)convert_message_to_dictset toNone, parametrized overhuman -> user,ai -> assistant,system -> system, and an unmappedtool -> tool(guards against the old hardcoded'user')ValueErroron an unsupported objectLangChain is not installed in this env, so the tests monkeypatch
llm_utils.LangchainBaseMessageto a localFakeLangchainMessage(.type/.content) to exercise the branch deterministically.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/6d82f0caa4c445eca0a304dedd7d6168
Open in Devin Desktop: https://app.devin.ai/desktop/session/6d82f0caa4c445eca0a304dedd7d6168?variant=devin