Repository navigation
Test inspect_results summary statistics and error bucketing - #25
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…g; bug: keep full err_msg when no logs marker
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the coverage gap flagged by the code scan: the headline benchmark numbers (
get_std_err,get_sample_std_err,summarize) and error bucketing (map_err_key,error_report) insrc/agentlab/analyze/inspect_results.pyhad no direct tests, so a regression would silently misreport results.New
tests/analyze/test_inspect_results_stats.py(21 tests) builds small hand-made dataframes and asserts:get_std_erron binary rewards matches the Bernoulli formula, drops NaNs, and gives0for an all-success frame; non-binary rewards delegate toget_sample_std_err.get_sample_std_errmatchesstd(ddof=1)/sqrt(n)and normalizes the singleton NaN to0.summarizeon a mixed success/error frame:avg_reward,std_err,avg_steps,n_completed(errored runs count as completed, unfinished ones do not),n_err,cum_cost, andcum_effective_costreplacingcum_cost; plusNonewhen nothing completed, the no-cum_rewardbranch, andAssertionErrorwhen an errored run carries non-zero reward.map_err_keystrips the=== logs ===tail and normalizes token counts and task names so equivalent failures collapse;error_reportbuckets them, lists tasks sorted by name, and honoursmax_stack_trace(get_exp_resultis monkeypatched with lightweight fakes).One behavior fix was needed to make bucketing correct:
map_err_keysliced onerr_msg.find("=== logs ===")unconditionally, so a message with no logs marker lost its last character (findreturns-1).pytest tests/analyzepasses (24 tests);black --checkclean.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/2ac2d4e40de941eda7cea079da93e133
Open in Devin Desktop: https://app.devin.ai/desktop/session/2ac2d4e40de941eda7cea079da93e133?variant=devin