Repository navigation
test: cover StepInfo save/load round-trip in loop.py - #24
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes a code scan coverage gap: nothing in
tests/exercisedStepInfo.save_step_info/ExpResult.get_step_info, so a regression in the screenshot/goal-object offload or inDataclassJSONEncoderwould silently corrupt saved episodes.New
tests/experiments/test_loop.pyusestmp_pathand no browser/env, asserting:obsin memory after savegoal_objectis offloaded togoal_object.pkl.gz, replaced by theNoneplaceholder, and re-hydrated byget_step_infosave_screenshot=False, save_som=Falseleaves no PNGs and load tolerates the missing filessave_json=Trueproducessteps_info.json, withDataclassJSONEncoderconverting numpy scalars/arrays and nested dataclassesDevin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/2a00f008474244b191b08214cae95b30
Open in Devin Desktop: https://app.devin.ai/desktop/session/2a00f008474244b191b08214cae95b30?variant=devin