Repository navigation
test: cover BaseMessage content builders and image base64 encoding - #23
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes a code-scan coverage gap:
BaseMessage.add_content/add_text/add_imageandDiscussion.add_imagehad no tests, so the string→list content promotion and the base64 image URL construction that feed vision-agent prompts could regress silently (malformed or dropped screenshots surface as a quality drop, not an error). Onlymerge()was tested.Tests added in
tests/llm/test_llm_utils.py, in the style of the existing merge tests:add_texton a string-bodied message promotes it to[{type: text, ...}, {type: text, ...}];add_contentappends to an already-list body.add_imagewith astrpasses the URL through (and attachesdetailwhen given).add_imagewith a PIL image and with an ndarray (parametrized) yieldsdata:image/jpeg;base64,...; the payload is decoded and reopened to assert it is a real JPEG of the original size.Discussion.add_imagemutates only the last message.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/bf387a97923c43d5843ab8af74cfa268
Open in Devin Desktop: https://app.devin.ai/desktop/session/bf387a97923c43d5843ab8af74cfa268?variant=devin