Repository navigation
test: cover Anthropic pricing lookup and version-suffix normalization - #21
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the test-coverage gap flagged by the code scan:
get_pricing_anthropicand_remove_version_suffixinsrc/agentlab/llm/tracking.pyhad no tests, so a normalization change could silently drop Claude models from the pricing map and makeset_pricing_attributesfall back to LiteLLM or zero cost.Tests added in
tests/llm/test_tracking.py(no production code changed):_remove_version_suffixcases asserting exact normalized keys for-vN,-vN:M, theanthropic.prefix, and a name with no suffix (e.g.anthropic.claude-3-sonnet-20240229-v1:0 -> claude-3-sonnet-20240229,anthropic.claude-v2:1 -> claude).get_pricing_anthropicwithbedrock_anthropic_callbackmonkeypatched to a fake exposing the two per-1K cost dicts, asserting the exact merged map (per-token prices, and entries present in only one of the input/output dicts keeping onlyprompt/completion).bedrock_anthropic_callbackisNone(langchain-community absent).Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/aa821337a6004090a4b20c95324a03e5
Open in Devin Desktop: https://app.devin.ai/desktop/session/aa821337a6004090a4b20c95324a03e5?variant=devin