Repository navigation
bug: test reproducibility compatibility, report verification and journal append - #20
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
… and journal append
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the long-commented-out (and stale, it referenced removed
save_reproducibility_info/load_reproducibility_info) test block intests/experiments/test_reproducibility_util.pywith active tests for the three untested gates flagged by the code scan:assert_compatible,_verify_report, andappend_to_journal.Tests build synthetic info dicts and report frames instead of running a study, so they are fast and need no MiniWoB server:
Covered behavior:
assert_compatible: passes when only volatile keys (date,avg_reward,std_err,n_completed,n_err) differ; raisesValueErroron a real key change; only logs a warning whenraise_if_incompatible=False._verify_report: raises on agent-name set mismatch, on duplicate agent names, onn_err > 0, and onn_completed != n_total; warns instead (and returns the frame indexed byagent.agent_name) whenstrict_reproducibility=False.append_to_journal: creates the CSV withagent_name(notagent_names) in the header, then a second call reuses the existing header and appends one row per agent (1 header + 3 rows); rejects agent-count mismatch between info and report; propagates_verify_reporterrors without creating the journal, and writes it when non-strict.pytest tests/experiments/test_reproducibility_util.py→ 15 passed;black --checkclean.Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/3cae64d756284de2a9a18602235aaf5a
Open in Devin Desktop: https://app.devin.ai/desktop/session/3cae64d756284de2a9a18602235aaf5a?variant=devin