Repository navigation
Test dict-style and zero-fallback branches of get_tokens_counts_from_response - #19
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code scan finding: only the object-attribute branch of
TrackAPIPricingMixin.get_tokens_counts_from_responsewas exercised, so a provider returning dict-styleusage(or no usable usage at all) could silently yield0, 0tokens and zero cost without any test catching it.Adds two parametrized unit tests in
tests/llm/test_tracking.pycalling the method directly on a bareTrackAPIPricingMixin():usage.input_tokens/output_tokens,usage.prompt_tokens/completion_tokens,{"usage": {"input_tokens", "output_tokens"}}and{"usage": {"prompt_tokens", "completion_tokens"}}(0, 0)and logging a warning when usage is missing or has no recognized fieldsNo production code changes.
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/fdc03943209f453880727c8bf2f12fc0
Open in Devin Desktop: https://app.devin.ai/desktop/session/fdc03943209f453880727c8bf2f12fc0?variant=devin