Skip to content

fix(importer): stopped incorrect persisting error messages #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
callumlewis05 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(importer): stopped incorrect persisting error messages #1102

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions ui/src/importer/Importer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,16 @@ export class Importer extends Component {
}

handleChange = (e, { name, value }) => {
this.setState({
[name]: value,
});
const update = { [name]: value };

if (name === "provider") {
update.providerMissing = false;
}
if (name === "mode") {
update.modeMissing = false;
}

this.setState(update);
};

handleCheckboxChange = (e, { name, checked }) => {
Expand Down Expand Up @@ -69,7 +76,12 @@ export class Importer extends Component {

handleSubmit = (action) => {
const { provider, mode, file, ignoreMissingRules } = this.state;
this.setState({ submitIsLoading: true });
this.setState({
submitIsLoading: true,
providerMissing: false,
modeMissing: false,
fileMissing: false,
});
let importMode = mode;
if (action === "PREVIEW" && mode === "IMPORT") {
importMode = "PREVIEW_IMPORT";
Expand Down Expand Up @@ -103,6 +115,7 @@ export class Importer extends Component {
const file = this.filesRef.current.files[0];
this.setState({
file: file,
fileMissing: false,
});
};

Expand Down Expand Up @@ -243,6 +256,7 @@ export class Importer extends Component {
value={provider}
options={invenioConfig.IMPORTER.providers}
onChange={this.handleChange}
onOpen={() => this.setState({ providerMissing: false })}
required
error={providerMissing ? "Please enter a provider" : null}
/>
Expand All @@ -255,6 +269,7 @@ export class Importer extends Component {
value={mode}
options={invenioConfig.IMPORTER.modes}
onChange={this.handleChange}
onOpen={() => this.setState({ modeMissing: false })}
required
error={modeMissing ? "Please enter a mode" : null}
/>
Expand All @@ -274,6 +289,9 @@ export class Importer extends Component {
labelPosition="left"
onClick={(e) => {
e.preventDefault();
this.setState({
fileMissing: false,
});
this.filesRef.current.click();
}}
/>
Expand Down
Loading