Conversation
…ERN#780) Replaces the erroneous `nextpow2` Poisson exponent with a photon count of 60000 (or `max(proj)/5` for very bright projections), matching the MATLAB `addCTnoise.m` reference. Also adds a clamp to 1e-6 before the `log` step to prevent `NaN` outputs when simulated noise pushes the projection to zero or below. Closes CERN#780
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #780
Description
Brings the Python
CTnoise.adddefaults into alignment with the MATLABaddCTnoise.mreference, preventing the function from returningNaNwhen simulating noise.nextpow2expression (which gave an exponent instead of a photon count) with a default of 60,000 photons (ormax(proj)/5for projections exceeding that).projections <= 0clamp to1e-6before taking the logarithm to ensure negative values produced by Gaussian noise do not result inNaNoutputs.