Conversation
added 2 commits
September 19, 2026 17:23
…d OS_* equivalents to remove code repetition
…ERN#782) Corrects the Python MSSIM implementation to match MATLAB: - Fixes parenthesis scoping in denominators: uses `(K1*d)**2` and `(K2*d)**2` instead of `K1*d**2` and `K2*d**2` - Updates K2 constant from 0.02 to 0.03 to match MSSIM.m - Applies ddof=1 to np.std() to use sample standard deviation as MATLAB does Closes CERN#782
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #782
Description
Aligns the Python MSSIM
Measure_Qualitycode with its MATLAB counterpart (MSSIM.m) to ensure the metric correctly yields a maximum value of1.0for identical images.(K1 * d) ** 2and(K2 * d) ** 2in denominators.K2from0.02to0.03.std()withstd(ddof=1)to apply N-1 normalization, matching MATLAB.