Revert "Release CUDA resources on error, and stop exit(1) in the Python binding" - #777
Merged
Merged
Conversation
yliu88au
added a commit
to liu005/TIGRE
that referenced
this pull request
Sep 7, 2026
…LastError, previously Python-only); fallback error text when the buffer is empty CERN#765 moved tigreSet/Get/ClearLastError() out of the IS_FOR_PYTIGRE block of Common/CUDA/TIGRE_common.cpp and made Atb_mex.cpp call tigreGetLastError(), but MATLAB/Compile.m never compiled TIGRE_common.cpp (before CERN#765 the file was Python-only), so the Atb mex target failed to link: unresolved tigreGetLastError. Reverted upstream in CERN#777. This adds the file to both Atb mex() lines (it is a plain C++ file; under MATLAB it compiles only the three last-error functions). Under MATLAB the CUDA-side macros still raise through the real mexErrMsgIdAndTxt(), so the buffer is empty when Atb_mex reports a non-CUDA status code - a fallback message replaces the empty string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #765
It Broke MATLAB compilation