Conversation
Rewrite plot_geometry.py with many new features: ie., flexible geometry display with animations
yliu88au
added a commit
to liu005/TIGRE
that referenced
this pull request
Sep 2, 2026
The test file was a commented-out visual inspection script; replaced with 8 headless (Agg) tests: static axes/scene, default-angles path, out-of-range pos fallback, both rotation modes rendered frame-by-frame via writer save, the fname save fallback chain, and calCube single/batched vertex geometry. The default-angles test caught a real bug: a default tigre.geometry() carries angles=None, so 'hasattr(ogeo, angles)' passed and check_geo crashed instead of falling back to linspace(0, 2pi, 100) - fixed with a None check. Preparation for an upstream PR (standalone module, no conflict with CERN#370).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite plot_geometry.py with many new features: ie., flexible geometry display with animations, Part 2 of previous PR#357