test(cli): skip recovery mode assertion on Windows - #85
Open
oscarricharingaoblitas-sketch wants to merge 1 commit into
Open
Conversation
oscarricharingaoblitas-sketch
marked this pull request as ready for review
August 13, 2026 14:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0600mode where permission bits are meaningfulWhy
Windows reports
fs.statSync(...).mode & 0o777as0o666even when the file is created with mode0o600, because Node.js does not implement POSIX file permission semantics on Windows. The unconditional mode assertion therefore made the CLI unit suite fail on native Windows despite the recovery file being written correctly.Impact
The recovery behavior is unchanged. The test remains strict on POSIX systems and now validates file existence without relying on unsupported permission semantics on Windows.
Validation
git diff --checkpassedpnpm pack:dry-runwas not run because this Windows environment does not providenpm; the change is test-only and does not affect packaged outputRelease decision
No release needed. This changes only a CLI test, so no package behavior or published output changes and no changeset is required.