Skip to content

test(cli): skip recovery mode assertion on Windows - #85

Open
oscarricharingaoblitas-sketch wants to merge 1 commit into
CALLE-AI:mainfrom
oscarricharingaoblitas-sketch:test/windows-recovery-file-mode
Open

test(cli): skip recovery mode assertion on Windows#85
oscarricharingaoblitas-sketch wants to merge 1 commit into
CALLE-AI:mainfrom
oscarricharingaoblitas-sketch:test/windows-recovery-file-mode

Conversation

@oscarricharingaoblitas-sketch

Copy link
Copy Markdown

Summary

  • keep verifying that the recovery cache file is created on every platform
  • only assert the POSIX 0600 mode where permission bits are meaningful

Why

Windows reports fs.statSync(...).mode & 0o777 as 0o666 even when the file is created with mode 0o600, because Node.js does not implement POSIX file permission semantics on Windows. The unconditional mode assertion therefore made the CLI unit suite fail on native Windows despite the recovery file being written correctly.

Impact

The recovery behavior is unchanged. The test remains strict on POSIX systems and now validates file existence without relying on unsupported permission semantics on Windows.

Validation

  • all repository JavaScript tests: 144 passed
  • CLI unit tests: 58 passed
  • CLI end-to-end tests: 15 passed
  • branch name, package version, install reference, runtime syntax, TypeScript, and plugin/skill metadata checks passed
  • git diff --check passed
  • pnpm pack:dry-run was not run because this Windows environment does not provide npm; the change is test-only and does not affect packaged output

Release decision

No release needed. This changes only a CLI test, so no package behavior or published output changes and no changeset is required.

@oscarricharingaoblitas-sketch
oscarricharingaoblitas-sketch marked this pull request as ready for review August 13, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant