Skip to content

Fix incorrect exit code for --list-triggers - #118

Merged
maltfield merged 1 commit into
BusKill:masterfrom
gokul000410:fix-list-triggers-exit-code
Jun 2, 2026
Merged

Fix incorrect exit code for --list-triggers#118
maltfield merged 1 commit into
BusKill:masterfrom
gokul000410:fix-list-triggers-exit-code

Conversation

@gokul000410

@gokul000410 gokul000410 commented May 27, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #116
Changed Exit Code For --list-triggers from 1 to 0 .

The command successfully lists available Triggers, so it should be return a success exit status instead of an error status.

@github-actions

Copy link
Copy Markdown

INFO: No unicode characters found in PR's commits

(source)

@github-actions

Copy link
Copy Markdown

INFO: No unicode characters found in PR's commits

(source)

@github-actions

Copy link
Copy Markdown

INFO: No unicode characters found in PR's commits

(source)

@maltfield

Copy link
Copy Markdown
Member

@gokul000410 can you please send us an email so we can send you the CAA?

@gokul000410

Copy link
Copy Markdown
Contributor Author

@gokul000410 can you please send us an email so we can send you the CAA?

Hi, I already sent an email regarding the CAA from my email address : gokulkri247@gmail.com, but I haven't received a reply yet. Just checking if you received it.

@maltfield

Copy link
Copy Markdown
Member

@gokul000410 can you please send us an email so we can send you the CAA?

Hi, I already sent an email regarding the CAA from my email address : gokulkri247@gmail.com, but I haven't received a reply yet. Just checking if you received it.

Sorry for the delay, and thanks for pinging us again. Please check your inbox for the CAA.

Also, can you please confirm that this PR (including the code, comments and the PR text itself) was written by you, and not aided with any AI tools (which we do not allow in this project).

@gokul000410

gokul000410 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for the delay, and thanks for pinging us again. Please check your inbox for the CAA.

Also, can you please confirm that this PR (including the code, comments and the PR text itself) was written by you, and not aided with any AI tools (which we do not allow in this project).

Yes , I Confirm Code and The PR Text was written by me not by any ai tools and I also signed the CAA

@maltfield
maltfield merged commit c1e492f into BusKill:master Jun 2, 2026
3 checks passed
@maltfield

Copy link
Copy Markdown
Member

Thanks! I've also confirmed that we've received the signed CAA.

@maltfield

Copy link
Copy Markdown
Member

@gokul000410 whoops, sorry, I reverted the merge.

You made this PR from the master branch -- which is our old & stable branch.

Please recreate this change for merging into the dev branch, and I'll merge it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: --list-triggers exits with error code 1 instead of 0

2 participants