Skip to content

Revert "Add golden snapshot trigger workflow" - #408

Merged
samijaber merged 1 commit into
mainfrom
revert-394-pablo/golden-snapshot-workflow
Sep 24, 2026
Merged

samijaber merged 1 commit into
mainfrom
revert-394-pablo/golden-snapshot-workflow

Conversation

@samijaber

Copy link
Copy Markdown
Contributor

Reverts #394.

complementary to #406: we no longer need this file in main because we're inlining it into the sync.yml in the template branch

@samijaber
samijaber requested review from a team and liamdebeasi and removed request for a team September 24, 2026 13:37
@samijaber

Copy link
Copy Markdown
Contributor Author

Pairs with #406, which removes the reason this file has to exist: sync.yml currently dispatches it by name, and #406 replaces that dispatch with the API call inlined into the sync job.

Please merge #406 first. If this merges while sync.yml still dispatches create-template-snapshot.yml, the next push to template fails at the dispatch step with a 404.

Context: main is what Fusion clones, so it should carry no workflow files at all — goldens were baking the starter's .github and shipping it into customer repos, which then blocked those customers from pushing (the Builder GitHub App has no workflows permission). Full write-up in #406.

samijaber added a commit that referenced this pull request Sep 24, 2026
* ci(sync): request the golden snapshot inline

main ships in every clone of the starter, so it must carry no workflow
files. The sync dispatched create-template-snapshot.yml on main purely
because it needed a dispatch target; the request itself is a single API
call and sync.yml already holds the pushed main SHA at that point.

Moving it here rather than into BuilderIO/agent-native: the monorepo
only ever pushes the template branch and never learns the main SHA the
merge plus overlay produces, so it would have to poll for main to
advance and could bake the wrong commit. Secrets are repo-level, so
nothing needs reconfiguring.

* ci(starter-patch): delete the snapshot workflow from main

main is machine-written by sync.yml, so the workflow has to be removed
through the overlay delete list rather than by a commit on main.
apply.mjs runs after the .github restore, so deleteListed drops it on
every sync and stays idempotent.

* Revert delete.txt entry; #408 removes the workflow from main directly
@samijaber
samijaber merged commit dac74b8 into main Sep 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants