Skip to content

Add Beta regression coverage for transaction writes - #6535

Merged
steve8708 merged 2 commits into
mainfrom
steve8708/fix-transaction-access-followup
Oct 1, 2026
Merged

steve8708 merged 2 commits into
mainfrom
steve8708/fix-transaction-access-followup

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

Summary

  • Add a Beta E2E check for Design visual edits that persist through inline source writes.
  • Add a Beta E2E check for Analytics dashboard create, rename, readback, and cleanup.
  • The shared transaction fix is already merged in Fix pooled transaction query routing #6423; this PR adds coverage for two reported app paths.

Verification

  • pnpm guards passed all 82 checks.
  • Core transaction scope tests passed 17/17.
  • The deployed Content Beta E2E edit and comment path passed in run 36845333670.
  • Targeted Analytics and Design Beta E2E runs will verify the new journeys against the deployed sites.

Test fixture limit

The Beta E2E account cannot create a pinned Google Slides native item: it has no Google Drive grant or Creative Context Lab setup. The Slides clone call path is covered by Core scope and Slides action tests, but needs a dedicated Drive-backed beta fixture for a live clone check.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Review Summary

The latest commit updates the two Beta regression specs without changing application code. In the Design test, it now supplies a UUID at creation and asserts the returned top-level ID, and teardown aggregates cleanup failures with the primary test failure. In the Analytics test, deletion is checked via a 404 readback and a listing that includes archived and hidden dashboards. These changes address all three concerns from the prior review. Both independent review passes found no new actionable issues. Risk remains low because this is test-only coverage; the action/readback assertions and cleanup checks are appropriate for the reported transaction paths.

🧪 Browser testing: Skipped — PR only modifies Beta E2E test files, with no user-facing UI impact.

@steve8708
steve8708 merged commit 17ed40d into main Oct 1, 2026
37 of 38 checks passed
@steve8708
steve8708 deleted the steve8708/fix-transaction-access-followup branch October 1, 2026 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant