Skip to content

Wait for Content collaboration before Beta comment selection - #6476

Merged
steve8708 merged 3 commits into
mainfrom
steve8708/changes-12002
Sep 30, 2026
Merged

steve8708 merged 3 commits into
mainfrom
steve8708/changes-12002

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

Summary

Wait for Content's collaborative editor to become editable after reload before selecting text for the comment flow.

Why

Beta E2E run 36750119285 showed the edited text persisted after reload, but the test selected text before the collaboration sync re-enabled the editor.

Verification

  • pnpm exec oxfmt --write e2e/beta/specs/apps/content-edit-comment.spec.ts
  • pnpm e2e:beta --project=journeys --grep 'Content beta saves a page edit and comment' --list selected one test

builder-io-integration[bot]

This comment was marked as outdated.

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

This update adds explicit contenteditable="true" waits for the Content editor, both after initial navigation and after reload. Importantly, the reload and persisted-body check now happen before text selection and comment creation, addressing the prior review’s coverage gap: the journey exercises the collaborative editor becoming ready after reload, rather than waiting only on the initial editor.

The approach is focused and suitable for this low-risk E2E-only change. Both independent reviews found no remaining confirmed issues. One agent could not run the listed Playwright discovery command because pnpm was unavailable in its environment; no visual/browser run was applicable because application UI code was not changed.

🧪 Browser testing: Skipped — PR only modifies an E2E test, with no user-facing UI impact.

@steve8708
steve8708 merged commit ed4851d into main Sep 30, 2026
47 checks passed
@steve8708
steve8708 deleted the steve8708/changes-12002 branch September 30, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant