Wait for Content collaboration before Beta comment selection - #6476
Conversation
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
This update adds explicit contenteditable="true" waits for the Content editor, both after initial navigation and after reload. Importantly, the reload and persisted-body check now happen before text selection and comment creation, addressing the prior review’s coverage gap: the journey exercises the collaborative editor becoming ready after reload, rather than waiting only on the initial editor.
The approach is focused and suitable for this low-risk E2E-only change. Both independent reviews found no remaining confirmed issues. One agent could not run the listed Playwright discovery command because pnpm was unavailable in its environment; no visual/browser run was applicable because application UI code was not changed.
🧪 Browser testing: Skipped — PR only modifies an E2E test, with no user-facing UI impact.
Summary
Wait for Content's collaborative editor to become editable after reload before selecting text for the comment flow.
Why
Beta E2E run 36750119285 showed the edited text persisted after reload, but the test selected text before the collaboration sync re-enabled the editor.
Verification
pnpm exec oxfmt --write e2e/beta/specs/apps/content-edit-comment.spec.tspnpm e2e:beta --project=journeys --grep 'Content beta saves a page edit and comment' --listselected one test