Skip to content

chore: ignore generated data directories in scaffolds - #4610

Merged
steve8708 merged 1 commit into
mainfrom
steve8708/changes-7140
Sep 9, 2026
Merged

chore: ignore generated data directories in scaffolds#4610
steve8708 merged 1 commit into
mainfrom
steve8708/changes-7140

Conversation

@steve8708

Copy link
Copy Markdown
Contributor

Summary

  • ignore every data/ directory in the framework checkout
  • propagate the rule through first-party template and bundled scaffold _gitignore sources
  • remove the tracked local PGlite lock from the repository while preserving local runtime data

Validation

  • git diff --check
  • scaffold source coverage check for all _gitignore files
  • git check-ignore --no-index for root, nested, and generated-template data paths

The generated data directories are local runtime state and must not enter generated Agent-Native repos.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Code Review Summary

PR #4610 broadens the repository and scaffold .gitignore rules from only selected runtime paths to every data/ directory, updates the first-party template sources consistently, and removes the stale tracked PGlite lock file. The approach is sound: the **/data/ pattern covers both root-level and nested generated runtime directories, while the existing runtime-specific entries remain harmless and preserve documentation of expected data contents. Independent reviews also confirmed that PGlite locking remains runtime-managed and that no other tracked data/ artifacts are left behind.

This is a low-risk repository/scaffold configuration change. No confirmed bugs, data-loss risks, crashes, or security issues were found. The source coverage and ignore semantics match the stated goal.

🧪 Browser testing: Skipped — PR only modifies backend/config/docs, no UI impact

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

@steve8708
steve8708 merged commit 1a741ea into main Sep 9, 2026
47 checks passed
@steve8708
steve8708 deleted the steve8708/changes-7140 branch September 9, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant