Add personal sidebar sections and exact View recency - #4609
Draft
3mdistal wants to merge 6 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content's sidebar needs to remember where a person actually visited and let them arrange their own navigation. This adds exact saved-View Recent entries and personal Pinned/Recent section controls for SB-11–13. For example, visiting a database's Table and Board creates distinct Recent links; choosing Table returns to that View even after Board was last active.
Recent retains at most fifty target identities and visit timestamps, resolves current titles under the current user's access, and records successful foreground visits. Section order, visibility, expansion and displayed counts persist per user. Pin ordering uses atomic personal navigation patches that preserve other saved preferences and inherited filters. Keyboard Enter still follows links; Space starts reordering, with focus retained after saving. Personal navigation does not write canonical parentage, membership, permissions or shared View configuration.
The implementation uses the shared Actions and personal-state surface, includes translations for the added controls, and records bounded evidence in the sidebar Capability. It does not promote the whole Capability beyond approved_shape. No package source or schema migration is included. The app's changelog command is disabled by its existing configuration.
Validation on the isolated authenticated local node-server build:
This remains a draft. Additional composed checks pass unopened Action edits leaving Recent unchanged, section Move up/down, failed preference-save rollback, failed Recent read/Retry recovery, and external same-owner deletion removing mounted Recent. Cross-account revocation initially exposed missing recipient event delivery. Repaired composed replay now passes with D1 #4607 at 03526de: an actual direct-user revoke records a recipient notification, triggers Recent refetch, and removes the title without reload. This is direct-user Recent refresh proof only; role/org/public changes and post-revocation editor write races are outside this slice. Integration still requires that dependency. Pin row menus have no Move up/down commands in this frozen build; pointer/keyboard row reordering and section menu reordering are the verified controls. No merge or deployment is requested.
CI recovery at ffb7af8 fixes introduced lint errors, Action parity registration and instruction size. Full Content parity passes 143 tests locally; GitHub Lint & format, Content parity and Security guards pass. The subsequent fast-test failure was a stale assertion that the sidebar container still imported IconPin. Test-only commit 223d290 scopes glyph checks to the actual Pin command components; 36 affected tests pass. New CI is pending, and runtime behavior is unchanged. All QA-only source overlays were removed; this branch remains clean and draft.
Local check limitations: the repository i18n catalog guard reports 2,537 existing issues; changed-copy reports zero inspected surfaces on this Windows checkout and provides no meaningful pass. The non-CLI Content-impact subset has 21 passes and three CRLF-sensitive fixture/workflow failures; six CLI-boundary tests were excluded after Windows extensionless-tsx launch failures. No guard or localization baseline was weakened. These checks require resolution or verified baseline disposition before readiness.