Fix feedback regressions and beta schema gate - #4592
Conversation
This comment has been minimized.
This comment has been minimized.
|
Here's a visual recap of what changed: Open the full interactive recap |
|
Addressed the review summary in 1ea2170: NotReadableError and legacy TrackStartError now trigger fallback only in audio acquisition, so camera failures keep their existing classification. The CORP concern is intentionally unchanged for the framing contract explained in the inline reply. |
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
The latest PR expands the earlier fixes with first-run setup and CLI guidance, deployment/documentation updates, provider validation and save-error handling, Cloudflare static-header rule changes, and local PGlite reload persistence. The prior security-header iframe/CORP comment remains an existing open issue and was not reposted. The parallel review workers were interrupted before returning findings, so this review records no newly confirmed issues rather than speculating from incomplete results. The PR remains high risk because it spans setup, deployment, security headers, persistence, and provider configuration.
🧪 Browser testing: Not completed in this interrupted review; the latest changes include user-facing setup/settings and documentation flows that require follow-up browser verification.

Summary
notified_atmigration has not reached a site yet_headersbelow the 100-rule platform limit without dropping required static security headersFeedback disposition
list-resource-sharesSentry failures caused by reads of the not-yet-migratednotified_atcolumnactions/hello.tslocation, temporary Vercel preview guidance, andagentNativePluginsnamingnpxrun now suppresses npm's confirmation prompt; the published package has no postinstall script and the reporter's cached retry was immediateview-screendiscovery, local auth-env warnings, docs-link latency, Builder file-storage setup, prompt-copy scope, deployment-provider grouping, absent MCP tooling, Builder credit reconnection, and chooser densityVerification
corepack pnpm guards- 71/71 passedcorepack pnpm --filter @agent-native/core typecheckcorepack pnpm --filter @agent-native/dispatch typecheckcorepack pnpm --filter clips-desktop typecheck_headerscontains 7 rules with required static security headers intactgit diff --checkpassedLive headset hardware, authenticated browser flows, beta deployment, and production migration were not exercised locally.