Skip to content

Fix feedback regressions and beta schema gate - #4592

Merged
steve8708 merged 8 commits into
mainfrom
changes-7123
Sep 9, 2026
Merged

Fix feedback regressions and beta schema gate#4592
steve8708 merged 8 commits into
mainfrom
changes-7123

Conversation

@steve8708

@steve8708 steve8708 commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep share dialogs readable when an additive notified_at migration has not reached a site yet
  • make the beta schema gate fail loudly when its matcher cannot run instead of treating the failure as "no schema changes"
  • reserve COEP isolation for validated MCP embed sessions so ordinary iframe previews can load cross-origin Builder assets
  • retry another microphone when the selected Clips desktop input cannot start, and reuse that fallback in the setup meter
  • make first-run setup fail clearly below Node 22.22, ignore generated PGlite lock files, and clarify the pnpm and React-route instructions
  • remove contradictory account-only copy from the local-development sign-in path
  • give failed Slack identity checks a direct recovery path
  • keep Cloudflare Workers _headers below the 100-rule platform limit without dropping required static security headers
  • allow loopback Ollama endpoints in non-production and show provider-save failures in Settings
  • correct standalone deployment commands and clarify local versus deployed configuration across the deployment docs and translations
  • preserve one local PGlite client across Vite reload realms so edits do not lock the database or hide persisted settings
  • repair the Docker install layer and clarify the local source path, Vite plugin alias, and account-free Vercel preview limits

Feedback disposition

Verification

  • corepack pnpm guards - 71/71 passed
  • corepack pnpm --filter @agent-native/core typecheck
  • corepack pnpm --filter @agent-native/dispatch typecheck
  • corepack pnpm --filter clips-desktop typecheck
  • Core launcher and scaffold suites: 55/55 passed
  • auth-page suite: 11/11 passed
  • Dispatch identity suite: 32/32 passed
  • security-header regression: 10/10 passed
  • pending-migration share-list regression: 1/1 passed
  • Clips media fallback suite: 7/7 passed
  • Netlify prebuilt workflow suite: 32/32 passed
  • Core deployment and provider-settings suites: 185/185 passed
  • PGlite client suite: 69/69 passed, including a fresh-realm reload regression
  • generated standalone Chat smoke passed through scaffold, install, dev startup, local auth, and browser navigation with clean server/browser logs
  • standalone scaffold native-build configuration suite: 15/15 selected tests passed
  • real Chat Cloudflare-module build passed; generated _headers contains 7 rules with required static security headers intact
  • modified source formatting and git diff --check passed

Live headset hardware, authenticated browser flows, beta deployment, and production migration were not exercised locally.

@steve8708 steve8708 added the codex label Sep 9, 2026
@netlify

This comment has been minimized.

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Here's a visual recap of what changed:

Visual recap

Open the full interactive recap

builder-io-integration[bot]

This comment was marked as outdated.

@steve8708

Copy link
Copy Markdown
Contributor Author

Addressed the review summary in 1ea2170: NotReadableError and legacy TrackStartError now trigger fallback only in audio acquisition, so camera failures keep their existing classification. The CORP concern is intentionally unchanged for the framing contract explained in the inline reply.

builder-io-integration[bot]

This comment was marked as outdated.

@builder-io-integration builder-io-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder reviewed your changes — looks good ✅

Review Details

Incremental Code Review Summary

The latest PR expands the earlier fixes with first-run setup and CLI guidance, deployment/documentation updates, provider validation and save-error handling, Cloudflare static-header rule changes, and local PGlite reload persistence. The prior security-header iframe/CORP comment remains an existing open issue and was not reposted. The parallel review workers were interrupted before returning findings, so this review records no newly confirmed issues rather than speculating from incomplete results. The PR remains high risk because it spans setup, deployment, security headers, persistence, and provider configuration.

🧪 Browser testing: Not completed in this interrupted review; the latest changes include user-facing setup/settings and documentation flows that require follow-up browser verification.

@steve8708
steve8708 merged commit 554c771 into main Sep 9, 2026
51 of 52 checks passed
@steve8708
steve8708 deleted the changes-7123 branch September 9, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant