UX Fixed for Clips by shawnmcclelland · Pull Request #4531 · BuilderIO/agent-native

shawnmcclelland · 2026-09-08T21:02:08Z

Fixes the issue where comments weren't scrollable on larger displays. Relocates comments back to right side panel.
Fixes issue where tabs in side panel weren't using the proper shadcn component and underline variants.
Re-implements the Send Feedback affordance in the left nav so users can submit feedback directly in the app.
Address a consistency issue in how split buttons are structure in the toolbar to use a shared component and fixes the incorrect corner radii.
Fixes a bug where the user could not expand left nav items that had sub-items without clicking on them (Library and Spaces).
Fixes an issue where cmd+k would spawn two different command palettes. Also introduces contextual entries into the cmd+k system so the menu is based on the active route.
Implemented proper folder structure and organization in the Library view as well as adding context menu to create a folder from empty space.
Fixed an issue where certain routes were not displaying the correct empty state.

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=2 issued_at=2026-09-08T21:16:00Z expires_at=2026-09-08T21:26:00Z observed_legacy_heartbeat_version=none legacy_retired=true

github-actions · 2026-09-08T21:17:14Z

Here's a visual recap of what changed:

Open the full interactive recap

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=3 issued_at=2026-09-08T21:51:42Z expires_at=2026-09-08T22:01:42Z observed_legacy_heartbeat_version=none legacy_retired=true

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=4 issued_at=2026-09-08T22:00:46Z expires_at=2026-09-08T22:10:46Z observed_legacy_heartbeat_version=none legacy_retired=true

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=5 issued_at=2026-09-08T22:05:37Z expires_at=2026-09-08T22:15:37Z observed_legacy_heartbeat_version=none legacy_retired=true

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=6 issued_at=2026-09-08T22:09:06Z expires_at=2026-09-08T22:19:06Z observed_legacy_heartbeat_version=none legacy_retired=true

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=7 issued_at=2026-09-08T22:15:22Z expires_at=2026-09-08T22:25:22Z observed_legacy_heartbeat_version=none legacy_retired=true

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=8 issued_at=2026-09-08T22:36:05Z expires_at=2026-09-08T22:46:05Z observed_legacy_heartbeat_version=none legacy_retired=true

Restore mounted dictation deep-link expansion and compact share-comment scrolling. Remove unused imports and default-surface eyebrow flagged by CI.

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=9 issued_at=2026-09-08T22:46:16Z expires_at=2026-09-08T22:56:16Z observed_legacy_heartbeat_version=none legacy_retired=true

Stack footer utilities in the collapsed rail and give the org switcher the same hit target and icon scale as the neighboring controls.

The runtime PID lock is already covered by the repository PGlite lock ignore rule and must not be persisted in the PR.

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=10 issued_at=2026-09-08T22:58:00Z expires_at=2026-09-08T23:08:00Z observed_legacy_heartbeat_version=none legacy_retired=true

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=11 issued_at=2026-09-08T23:14:30Z expires_at=2026-09-08T23:24:30Z observed_legacy_heartbeat_version=none legacy_retired=true

builder-io-integration

Builder reviewed your changes and found 1 potential issue 🟡

Review Details

Code Review Summary

This incremental review covers the latest route and UX refinements: shared breadcrumb inputs were added to folder/space views, empty-state and trash routes were aligned, comments navigation was consolidated, and dictation command-menu deep links were extended. The already-open folder-loading issue remains unchanged and was intentionally not reposted. The prior Cmd/Ctrl+K native-control issue also remains open and was not duplicated. The latest implementation correctly centralizes public-share comment-panel selection and keeps the generated database lock removed.

Key Findings

🟡 MEDIUM — Dictation search results navigate with ?dictationId=, and the row expands visually, but shared application navigation state still does not parse that query parameter. The agent therefore sees only the Dictate view and not the selected dictation, leaving URL, UI, and agent-visible state inconsistent.

🧪 Browser testing: Will run after this review (PR touches UI code)

builder-io-integration

Builder reviewed your changes and found 3 potential issues 🟡

Review Details

Code Review Summary

This incremental review covers the latest PR head after the folder-query fix. The organization ID is now passed into the library folder query, so the previously reported folder-card loading issue is resolved and its review thread has been cleared. The dictation deep-link issue remains present and was intentionally skipped because it is already open. The remaining changes continue to affect shared command-menu filtering, library context menus, and viewer tab lifecycle, so this remains standard risk.

Key Findings

🟡 MEDIUM — Recording-specific command-menu items are wrapped in a fragment that the shared manual filter does not recurse into, leaving contextual commands visible for unrelated searches.
🟡 MEDIUM — The new canvas context menu wraps recording cards and can compete with each card’s existing context menu on right-click.
🟡 MEDIUM — Moving comments into tab content can unmount the comments panel and discard unsent drafts when users switch tabs.
⚪ LOW — The bug-report severity selector is not associated with its visible label.

The parallel reviewers found no additional confirmed regressions. Focused tests reported by the agents passed where runnable, with environment-specific typecheck/alias limitations.

🧪 Browser testing: Will run after this review (PR touches UI code)

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=12 issued_at=2026-09-08T23:26:00Z expires_at=2026-09-08T23:36:00Z observed_legacy_heartbeat_version=none legacy_retired=true

builder-io-integration

Builder reviewed your changes — no new findings

Review Details

Code Review Summary

This incremental review covered the latest PR head, including the expanded library-grid tests, breadcrumb and empty-state updates, query-selected dictation handling, recording viewer tab changes, and the prior folder-loading fix. The four already-open review topics were not reposted. The parallel reviewers found no additional confirmed regressions in routing, folder scoping, command-menu behavior, comments/responsive layout, bug-report flow, desktop lifecycle, or localization/accessibility. The latest folder query now supplies the organization ID and gates loading appropriately, addressing the prior finding. This remains a standard-risk UI and routing change with useful focused regression coverage.

🧪 Browser testing: Will run after this review (PR touches UI code)

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=14 issued_at=2026-09-09T00:13:47Z expires_at=2026-09-09T00:23:47Z observed_legacy_heartbeat_version=none legacy_retired=true

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=15 issued_at=2026-09-09T00:24:22Z expires_at=2026-09-09T00:34:22Z observed_legacy_heartbeat_version=none legacy_retired=true

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=16 issued_at=2026-09-09T00:34:30Z expires_at=2026-09-09T00:44:30Z observed_legacy_heartbeat_version=none legacy_retired=true

pr=4531 owner_thread=01a08188-2e33-7e22-ad3f-e5bf4271fca8 version=17 issued_at=2026-09-09T00:42:36Z expires_at=2026-09-09T00:52:36Z observed_legacy_heartbeat_version=none legacy_retired=true

# Conflicts: # templates/clips/app/hooks/use-navigation-state.ts # templates/clips/app/routes/_app.r.$recordingId.test.ts # templates/clips/app/routes/_app.r.$recordingId.tsx # templates/clips/data/pglite.agent-native-pglite.lock

# Conflicts: # templates/clips/app/components/player/share-dialog.test.ts # templates/clips/app/components/player/share-dialog.tsx

Update Clips recording and agent workflows

a9469f7

shawnmcclelland requested a review from steve8708 September 8, 2026 21:02

shawnmcclelland self-assigned this Sep 8, 2026

steve8708 approved these changes Sep 8, 2026

View reviewed changes

Merge branch 'main' into ux-fixes

ed7f000

This comment was marked as outdated.

Sign in to view

fix: resolve PR review and CI feedback

e814bee

Restore mounted dictation deep-link expansion and compact share-comment scrolling. Remove unused imports and default-surface eyebrow flagged by CI.

This comment has been minimized.

Sign in to view

fix: align collapsed Clips sidebar controls

1f7f0b5

Stack footer utilities in the collapsed rail and give the org switcher the same hit target and icon scale as the neighboring controls.

This comment was marked as outdated.

Sign in to view

chore: remove generated Clips database lock

b932fce

The runtime PID lock is already covered by the repository PGlite lock ignore rule and must not be persisted in the PR.

This comment was marked as outdated.

Sign in to view

fix: unify Clips route breadcrumbs

4a032d6

builder-io-integration Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread templates/clips/app/routes/_app.dictate.tsx

fix: scope folder queries to the active organization

6dcc509

builder-io-integration Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread templates/clips/app/components/clips-command-menu.tsx

Comment thread templates/clips/app/components/library/library-grid.tsx

Comment thread templates/clips/app/routes/_app.r.$recordingId.tsx

Merge origin/main into ux-fixes

7d1d1cb

builder-io-integration Bot reviewed Sep 8, 2026

View reviewed changes

fix: resolve remaining Clips review findings

c1e77be

Merge origin/main into ux-fixes

c4c7b8e

shawnmcclelland added 8 commits September 8, 2026 17:44

fix: rebalance the sidebar feedback action

1b82d89

fix: simplify the sidebar feedback action

bfce827

feat: add library canvas import actions

42f8db5

fix: restore the canonical agent chat icon

5324dce

fix: show recording counts for folders

6f0e032

fix: align space pages with library shell

2a7d3f5

Improve library navigation and folder recording counts

365d138

fix: restore chromeless desktop popover

eee5ffd

steve8708 approved these changes Sep 9, 2026

View reviewed changes

shawnmcclelland added 2 commits September 9, 2026 08:23

Fix dark recorder switches and agent sidebar sizing

464c4f9

fix: use the global Agent panel on recordings

d5d5420

steve8708 approved these changes Sep 9, 2026

View reviewed changes

shawnmcclelland added 4 commits September 9, 2026 12:58

Improve Clips recording and transcript workflows

59a602a

chore: publish branch work in templates/clips (3 files)

edd3a97

Merge remote-tracking branch 'origin/main' into ux-fixes

f80ad82

# Conflicts: # templates/clips/app/components/player/share-dialog.test.ts # templates/clips/app/components/player/share-dialog.tsx

This comment was marked as resolved.

Sign in to view

test: avoid credential-shaped JWT fixture

2372b56

shawnmcclelland enabled auto-merge (squash) September 9, 2026 21:41

test: tolerate transient scaffold cleanup races

639e218

shawnmcclelland disabled auto-merge September 9, 2026 22:03

steve8708 approved these changes Sep 9, 2026

View reviewed changes

shawnmcclelland merged commit 63f77f0 into main Sep 9, 2026
51 checks passed

shawnmcclelland deleted the ux-fixes branch September 9, 2026 22:17

Navigation Menu

Uh oh!

UX Fixed for Clips - #4531

UX Fixed for Clips#4531
shawnmcclelland merged 26 commits into
mainfrom
ux-fixes

shawnmcclelland commented Sep 8, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Sep 8, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

builder-io-integration Bot left a comment

Uh oh!

Uh oh!

builder-io-integration Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

builder-io-integration Bot left a comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

shawnmcclelland commented Sep 8, 2026

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

builder-io-integration Bot left a comment

Choose a reason for hiding this comment

Code Review Summary

Key Findings

Uh oh!

Uh oh!

builder-io-integration Bot left a comment

Choose a reason for hiding this comment

Code Review Summary

Key Findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

builder-io-integration Bot left a comment

Choose a reason for hiding this comment

Code Review Summary

Uh oh!

This comment was marked as resolved.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Sep 8, 2026 •

edited

Loading