fix: if you type /bp now, the latest applied filters are still there (menu doesn't reset anymore)#73
Merged
Zoriot merged 1 commit intoBuildTheEarth:buildfrom Feb 14, 2026
Merged
Conversation
Zoriot
added
⏰ medium priority
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the block palette menu behavior so that typing /bp now retains the previously applied filters instead of resetting to defaults. It also introduces /bp menu as an explicit command to reset filters to defaults.
Changes:
- Modified command structure to differentiate between
/bp(remembers filters) and/bp menu(resets to defaults) - Swapped primary command name from
blockpalettetobpin plugin.yml, making the shorter alias the primary command - Added null safety check in ModuleHandler to prevent NullPointerException when disabled modules list is null
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/resources/plugin.yml | Changed primary command from blockpalette to bp, updated aliases and usage text |
| src/main/java/net/buildtheearth/modules/miscellaneous/blockpalettegui/BlockPaletteCommand.java | Split /bp and /bp menu logic to support filter persistence vs reset behavior, updated help message |
| src/main/java/net/buildtheearth/modules/ModuleHandler.java | Added null check for disabled modules list to prevent potential NullPointerException |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Zoriot
requested changes
Feb 13, 2026
Collaborator
Zoriot
left a comment
Zoriot
left a comment
There was a problem hiding this comment.
Generally it seems to you have some unrelated changes which i made (possibly) in there.
Would be great if you can fix them. Create a new branch from build, cherry pick your commit(s), fix stuff like the imports and push it into this branch.
Should be easier then manually fixing everything
…(menu doesn't reset anymore) (cherry picked from commit 7fe6133)
Zoriot
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(menu doesn't reset anymore)