Fix Socket Port option

[glingy]

The socket port option documented in https://www.browsersync.io/docs/options/#option-socket did not affect anything. This allows the socket.port option to override the default port option so browser-sync can work in situations where the external port does not coincide with the internal port (ex: inside a docker container with fixed external port). With quick testing, this seems to allow the socket.port option to change the port the socket connects to from the client.

[glingy]

Note: helps issue #505 or at least improves the situation. I realize that in a docker container, this does not help much, but it is very helpful in other situations where browser-sync is behind a proxy.

[davidwindell]

This would be really great and would fix the problem I described in #419, @shakyShane could you, @crlang44 or another maintainer review this? Many thanks!

[crlang44]

I would certainly be surprised if I was a maintainer on this repo. Where do you see that?

[davidwindell]

Ah, it was on #1736, I must have mistook your acceptance of the review changes as being a maintainer

[davidwindell]

We couldn't wait for this so we've added a post-install script with sed to apply the patch:

"postinstall": "sed -i 's/var port = options/var port = socketOpts.port || options/g' node_modules/browser-sync/dist/connect-utils.js"

Works great!

[davidwindell]

@shakyShane any chance of getting this one merged?

[shakyShane]

I'd like to get this fixed, looking for a simple reproduction :)

[glingy]

It's been too long, I don't have a reproduction anymore and barely remember this issue.