GAUD-9944 - Fix sticky core components in d2l-page#6942
Draft
GAUD-9944 - Fix sticky core components in d2l-page#6942
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
svanherk
commented
May 6, 2026
Comment on lines
+30
to
+31
| /* stylelint-disable-next-line length-zero-no-unit -- used in calc() by consumers */ | ||
| --d2l-page-sticky-top: 0px; |
Contributor
Author
There was a problem hiding this comment.
Seems like our linting rules are just wrong here. 😕 But removing the px definitely breaks things.
svanherk
commented
May 6, 2026
Contributor
Author
There was a problem hiding this comment.
Things are a pixel or two off here - to be investigated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All our sticky components need to handle the proper offsets if they are in a
d2l-pagethat has a sticky header or are in a panel that has a sticky header.This needs to be more thoroughly tested, and it may not cover every sticky component we have (I think it does). But wanted to get it up before I go so it could be used/adjusted/merged if needed.