GAUD-9124: Removes auto-show attribute from d2l-overflow-group#6879
Open
EdwinACL831 wants to merge 4 commits intomainfrom
Open
GAUD-9124: Removes auto-show attribute from d2l-overflow-group#6879EdwinACL831 wants to merge 4 commits intomainfrom
EdwinACL831 wants to merge 4 commits intomainfrom
Conversation
- Removes from overflow-group-mixing.js the autoShow property - Removes vdiff tests related to the removed property - Updates README.md file - Updates HTML demo page for overflow-group
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
GAUD-9124
Description
The
auto-showattribute of thed2l-overflow-groupweb component is very confusing, and its behavior can be achieved by using themin-to-showandmax-to-showattributes too. In addition, most of the use cases of this feature is mainly using themin-to-showattribute. Therefore, we can stop supporting the confusingauto-showSolution
Related PRs