Skip to content

Return null from FaultGenerator when no fault is generated #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iancooper merged 1 commit into from
Sep 27, 2026
Merged

Return null from FaultGenerator when no fault is generated #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Paramore.Fences.Core/Simmy/Fault/FaultGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,6 @@ public FaultGenerator AddException<TException>(int weight = DefaultWeight)

var generatorDelegate = generator._helper.CreateGenerator();

return args => new ValueTask<Exception?>(generatorDelegate(args.Context)!.Value.Exception);
return args => new ValueTask<Exception?>(generatorDelegate(args.Context)?.Exception);
}
}
27 changes: 27 additions & 0 deletions test/Paramore.Fences.Core.Tests/Simmy/Fault/FaultGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,33 @@ public void AddException_FactoryWithResilienceContext_Ok()
Generate(generator).ShouldBeOfType<InvalidOperationException>();
}

[Fact]
public void ImplicitConversion_NoExceptionRegistered_ReturnsNull()
{
// Arrange
var generator = new FaultGenerator();

// Act
var fault = Generate(generator);

// Assert
fault.ShouldBeNull();
}

[Fact]
public void ImplicitConversion_AllWeightsZero_ReturnsNull()
{
// Arrange
var generator = new FaultGenerator();
generator.AddException<InvalidOperationException>(weight: 0);

// Act
var fault = Generate(generator);

// Assert
fault.ShouldBeNull();
}

private static Exception? Generate(FaultGenerator generator)
{
Func<FaultGeneratorArguments, ValueTask<Exception?>> func = generator;
Expand Down
Loading