Repository navigation
spec: 018 phase 1 — pagelint rule 8, ATTRIBUTE KIND - #198
Merged
Merged
Conversation
A sync handler attribute on HandleAsync, or an ...Async one on Handle, compiles and fails when Brighter builds the pipeline. Rule 8 reads every C# block for it: 017's attr_mismatch scan(), moved unchanged, with PAIRED (13 names, re-derived at Brighter 10.7.0 and master) beside APPLIES_TO. - per-block opt-out <!-- pagelint: attr-mismatch-intended <reason> -->, with three reported faults: no reason, no block after it, a second marker - --plant: five in-memory plants, run in CI; red-proof recorded - PipelineValidation.md block 7 marked: its Before (error) example - CLAUDE.md ledger row and section; tools/README.md rows 1-2 re-measured at 94ad0ed (#195 moved them: 524 -> 512 warnings, 165 -> 166 files) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LjnH2pJ98aMabu1MyTpRxy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 018 phase 1, tasks 1.1–1.8. Design § Rule 8 —
ATTRIBUTE KIND.What it does
tools/pagelint.pyrule 8. It catches a handler attribute of the wrong kind for its method, such as[RejectMessageOnError]onHandleAsync. That compiles, and then Brighter throwsConfigurationExceptionwhen it builds the pipeline. The check is 017's probescan(), moved unchanged.PAIRED(13 names) sits besideAPPLIES_TO, re-derived at Brighter10.7.0andmaster, which agree. It is an error repo-wide and under--changed.<!-- pagelint: attr-mismatch-intended <reason> -->binds to the next C# block. Three marker faults are reported as errors: no reason, no block after the marker, and a second marker on the same block.pagelint --plantruns five in-memory plants. It is added to CI as a bare step, because the one corpus hit is marked and the whole-repo run can no longer show the rule firing.CLAUDE.mdgets a ledger row and § Handler attributes match their handler.tools/README.mdgets thepagelintbullet,--plantin the modes list, and rows 1 and 2.Gates
linkcheckpagelintpagelint --plantsymbolcheckblockcheck --reportTwo figures moved before this phase started. #195 changed
pagelintwarnings from 524 to 512 (it repaired 12 debt blocks) andlinkcheckfiles from 165 to 166 (itsbugfix.md). Both are re-measured, with refs, intools/README.mdand intasks.md§ Phase 1 as executed. This phase moved no warning.Asking
PipelineValidation.md's Before (error) block. It renders as nothing, and no block's text changed.spec/018-phase1after the merge.🤖 Generated with Claude Code
https://claude.ai/code/session_01LjnH2pJ98aMabu1MyTpRxy