Repository navigation
Add outbox metrics - #4484
Add outbox metrics#4484
Conversation
|
taha-rafique seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thanks for this @taharafique It looks good to me, go ahead |
There was a problem hiding this comment.
@taharafique My main question is whether I always need an OutboxMeter. Typically, we would make this optional, so passing null means you have no meter and can return quickly from any meter-recording calls.
Typically, we would configure this as part of our setup of Telemetry and meters; see: src/Paramore.Brighter.Extensions.OpenTelemetry/OpenTelemetryBuilderExtensions.cs, and that ought to be where we enable it
This would also mean that you don't need to include it in BuildOutBoxProducerMediator because you would built it as part of the set up of our telemetry.
334a1b5 to
2c5e520
Compare
|
Thanks @taharafique |
Summary
Requirements and ADR for OpenTelemetry metrics on the Outbox (spec 0037). Docs only, no code changes yet.
Today the Outbox's only signal is trace spans. The add path often has a null span and production sampling drops the rest, so we have no aggregate view of Outbox volume or lag.
Proposal (ADR 0072)
OutboxProducerMediatorrecords to three instruments directly, behind a newIAmABrighterOutboxMeter. Nothing is derived from traces, so metrics record even when tracing is off or unsampled.paramore.brighter.outbox.added.messagesCounter<long>messaging.destination.nameparamore.brighter.outbox.cleared.messagesCounter<long>paramore.brighter.outbox.clear_source(explicit/sweeper/unknown)paramore.brighter.outbox.publish.durationHistogram<double>(s)OutboxClearSourceparameter.Open questions for maintainers
.durationvs.latencyfor the histogram nameCounter<long>vsCounter<int>, to matchMessagingMeterFiles
specs/0037-outbox-metrics/requirements.mddocs/adr/0072-outbox-metrics.md