Skip to content

Avoid zeroing full NumPy input blocks in miniexpr gather #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FrancescAlted merged 1 commit into from
Sep 29, 2026
+4 −1
Merged

Avoid zeroing full NumPy input blocks in miniexpr gather #728

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/blosc2/blosc2_ext.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2739,7 +2739,10 @@ cdef int aux_miniexpr(me_udata *udata, int64_t nchunk, int32_t nblock,
input_buffers[i] = malloc(block_nbytes)
if input_buffers[i] == NULL:
raise MemoryError("miniexpr: cannot allocate input block buffer")
memset(input_buffers[i], 0, block_nbytes) # zero padding, matches b2nd semantics
if valid_nitems < blocknitems:
# Partial blocks need zero-filled padding. Full blocks are
# overwritten byte-for-byte by the raw NumPy gather below.
memset(input_buffers[i], 0, block_nbytes)

np_ndim = udata.array.ndim
blosc2_unidim_to_multidim(np_ndim, udata.chunks_in_array, nchunk, chunk_ndim)
Expand Down
Loading