simplicity sys: prepare simplicity-sys 0.8.0 release - #382
Open
KyrylR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: we are bumping because of braking change of bitcoin_hashes dep
Ran the vendor command with the following command:
On this revision of Simplicity: BlockstreamResearch/simplicity@ba967b1
It is my first time doing such bump, so I am not entirely convinced that it is necessary, but AI reasoning (which is below) looks legit to me
Summary by GPT-6 Astra
Bump simplicity-sys to 0.8.0 ahead of the next Rust Simplicity release
The hash dependency update moved bitcoin_hashes from 0.14 to 1.x. Since simplicity-sys exposes these types in its public API, this is a breaking change and requires a version bump
Update the versioned C symbols, corresponding Rust bindings, and Cargo linking metadata to the 0.8 namespace. Update the workspace dependency requirements and lockfile accordingly. The vendored Simplicity revision and C implementation remain unchange
Verified that rerunning the vendoring script produces no Git diff