Skip to content

Identify host software in /report - #61

Open
yac wants to merge 2 commits into
mainfrom
generic_software_report
Open

yac wants to merge 2 commits into
mainfrom
generic_software_report

Conversation

@yac

@yac yac commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Accept optional software and software_version on /report so any host can register under its own name. Without software, add-ons still register as Blender from blender_version. Inconsistent identity is only logged, never rejected.

 {
   "app_id": 12345,
   "api_key": "",
   "addon_version": "0.5.0",
   "platform_version": "Linux",
-  "blender_version": "4.5.0",
+  "software": "Godot",
+  "software_version": "4.7.0",
   "project_name": "My project"
}

For software "Blender", software_version and blender_version are equivalent; software_version wins on conflict.

Decide browser download delivery and inactivity tolerance by the report endpoint that registered the software instead of its name, and only treat the registered version as a Blender version for Blender.

The change is fully backward compatible: requests without the new fields register and behave exactly as before, /godot/report is unchanged, and the /report response and API shapes stay the same.

Accept optional software and software_version on /report so any host can
register under its own name. Without software, add-ons still register as
Blender from blender_version. Inconsistent identity is only logged,
never rejected.

 {
   "app_id": 12345,
   "api_key": "",
   "addon_version": "0.5.0",
   "platform_version": "Linux",
-  "blender_version": "4.5.0",
+  "software": "Godot",
+  "software_version": "4.7.0",
   "project_name": "My project"
 }

For software "Blender", software_version and blender_version are
equivalent; software_version wins on conflict.

Decide browser download delivery and inactivity tolerance by the report
endpoint that registered the software instead of its name, and only
treat the registered version as a Blender version for Blender.

The change is fully backward compatible: requests without the new fields
register and behave exactly as before, /godot/report is unchanged, and
the /report response and API shapes stay the same.
@yac
yac force-pushed the generic_software_report branch from 4a8c81b to 68ab0f4 Compare September 25, 2026 12:51
@yac

yac commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

@agajdosi @Tweekazoid This (or something like this) is going to be needed for proper support of various addons - better done sooner than later I reckon.

I'm happy to discuss this and adapt per your feedback.

This branch was successfully deployed

1 active (outdated) deployment
signing — 4a8c81ba Deployed Sep 25, 2026 by github-actions[bot] via code_sign_windows #272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants